Correct two regressions in Spring codegen #2247
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes two significant regressions in Spring codegen:
After Divide Spring unit and integration testing in codegen #2230 I introduced a bug that lateinit variable
mockitoCloseableVariable
is not initialized. Fixed inCgSpringUnitTestClassConstructor
.After Fix StackOverflow errors in models with mocks processing #2157 I introduced a bug with missing mocks, now reverting changes. Stack overflow related problems still need to be fixed in Incorrect mocks are created for test with
ToStringCreator.append
#2158How to test
Automated tests
Codegen regression on
spring-petclinic
and similar projects.Manual tests
Manual verification of generated tests.
Self-check list